Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import picocolors as default #9949

Merged
merged 1 commit into from Nov 12, 2023
Merged

fix: import picocolors as default #9949

merged 1 commit into from Nov 12, 2023

Conversation

jaw0r3k
Copy link
Contributor

@jaw0r3k jaw0r3k commented Nov 12, 2023 •
edited

Please describe the changes this PR makes and why it should be merged:

Running: npm create discord-bot@0.2.2 throws commonjs module error caused by importing picocolors

image

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@jaw0r3k jaw0r3k requested a review from a team as a code owner November 12, 2023 19:34
@vercel Vercel
Copy link

vercel bot commented Nov 12, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2023 7:37pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2023 7:37pm

@Jiralite Jiralite added this to the create-discord-bot 0.3.0 milestone Nov 12, 2023
@kodiakhq kodiakhq bot merged commit 8a6045f into discordjs:main Nov 12, 2023
6 checks passed
@jaw0r3k jaw0r3k deleted the picocolors-fix branch November 12, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@Jiralite Jiralite Jiralite approved these changes

@suneettipirneni suneettipirneni suneettipirneni approved these changes

@monbrey monbrey Awaiting requested review from monbrey monbrey is a code owner automatically assigned from discordjs/guide

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/guide

@almostSouji almostSouji Awaiting requested review from almostSouji almostSouji is a code owner automatically assigned from discordjs/guide

Assignees
No one assigned
Labels
packages:create-discord-bot semver:patch
Projects
discord.js
Archived in project
Milestone
create-discord-bot 0.2.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jaw0r3k @vladfrangu @Jiralite @suneettipirneni