Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nodejs engine to 18 #9886

Open
JMTK opened this issue Oct 10, 2023 · 3 comments
Open

Update nodejs engine to 18 #9886

JMTK opened this issue Oct 10, 2023 · 3 comments
Labels
feature request packages:discord.js

Comments

@JMTK
Copy link
Contributor

JMTK commented Oct 10, 2023

Which application or package is this feature request for?

discord.js

Feature

Nodejs 16 is now EOL as of September 11 2023 and 18 is now LTS https://nodejs.dev/en/about/releases/

Ideal solution or implementation

Update all package engines to be 18+.

Experimental fetch is now enabled by default and can probably replace any undici references.

Alternative solutions or implementations

No response

Other context

No response
@ckohen
Copy link
Member

ckohen commented Oct 10, 2023

This will occur no earlier than the next major version (has already been done in many other packages).

Also of note, undici references will not be removed in discord.js. The main library is not intended to be used in browser environments, and undici request is more stable than fetch. Anything that can be used in browser / edge environments has already been updated to use global fetch when not in node (this includes in deno / bun).

@JMTK
Copy link
Contributor Author

JMTK commented Nov 8, 2023

Seems like this issue can be closed: ee2afb0

@Syjalo
Copy link
Contributor

Syjalo commented Nov 8, 2023

discord.js is still on v16. As @ckohen said

This will occur no earlier than the next major version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request packages:discord.js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JMTK @ckohen @Syjalo