fix(Role): calculate position correctly when rawPositions are equal #9872

vladfrangu · 2023-10-03T21:44:31Z

Diplopia of #9871

Please describe the changes this PR makes and why it should be merged:

Positions were not calculated right if a guild had raw positions equal across roles

This happened due to not noticing the previous sorting behavior which was (cleaned up from old v13)

function discordSort(collection) {
  return collection.sorted(
    (a, b) => a.rawPosition - b.rawPosition || Number(BigInt(b.id) - BigInt(a.id)),
  );
}

Peep the order: b.id - a.id. In current code, it's equivalent to a.id - b.id

Status and versioning classification:

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating

vercel · 2023-10-03T21:44:38Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Updated (UTC)
discord-js	⬜️ Ignored (Inspect)		Oct 3, 2023 9:44pm
discord-js-guide	⬜️ Ignored (Inspect)		Oct 3, 2023 9:44pm

fix(Role): calculate position correctly when rawPositions are equal

19ac35e

vladfrangu added priority:high regression semver:patch packages:discord.js labels Oct 3, 2023

vladfrangu requested review from a team, iCrawl, kyranet and SpaceEEC and removed request for a team October 3, 2023 21:44

Jiralite added the backport label Oct 3, 2023

Jiralite added this to the discord.js 13.17 milestone Oct 3, 2023

Jiralite mentioned this pull request Oct 3, 2023

fix(Role): calculate position correctly when rawPositions are equal #9871

Merged

Jiralite approved these changes Oct 7, 2023

View reviewed changes

kyranet approved these changes Oct 9, 2023

View reviewed changes

kodiakhq bot merged commit 56b481b into v13 Oct 9, 2023
13 checks passed

kodiakhq bot deleted the fix/v13/role-position-calculation branch October 9, 2023 07:22

fix(Role): calculate position correctly when rawPositions are equal #9872

fix(Role): calculate position correctly when rawPositions are equal #9872

vladfrangu commented Oct 3, 2023 •

edited

vercel bot commented Oct 3, 2023

fix(Role): calculate position correctly when rawPositions are equal #9872

fix(Role): calculate position correctly when rawPositions are equal #9872

Conversation

vladfrangu commented Oct 3, 2023 • edited

vercel bot commented Oct 3, 2023

vladfrangu commented Oct 3, 2023 •

edited