Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement guild.voiceAdapterCreator from discord.js into APIGuild from @discordjs/core #9752

Open
JayXTQ opened this issue Aug 6, 2023 · 2 comments
Open

Implement guild.voiceAdapterCreator from discord.js into APIGuild from @discordjs/core #9752

JayXTQ opened this issue Aug 6, 2023 · 2 comments
Assignees
@vladfrangu
Labels
feature request packages:core utility

Comments

@JayXTQ
Copy link

JayXTQ commented Aug 6, 2023 •
edited by kyranet

Which application or package is this feature request for?

core

Feature

Right now, the only implementation of guild.voiceAdapterCreator is in Discord.js:

discord.js/packages/discord.js/src/structures/Guild.js

Lines 1413 to 1427 in 85a78f9

get voiceAdapterCreator() {
return methods => {
this.client.voice.adapters.set(this.id, methods);
return {
sendPayload: data => {
if (this.shard.status !== Status.Ready) return false;
this.shard.send(data);
return true;
},
destroy: () => {
this.client.voice.adapters.delete(this.id);
},
};
};
}

Right now, this is quite annoying as I am using @discordjs/core for everything and I want to use voice as well, changing everything over may be a hassle and give me more issues compared to this singular issue.

Here is my thread on the Discord for more info: https://canary.discord.com/channels/222078108977594368/1137716614918320128/1137716614918320128

Ideal solution or implementation

Add voiceAdapterCreator to APIGuild

Alternative solutions or implementations

No response

Other context

No response
@vladfrangu vladfrangu self-assigned this Aug 6, 2023
@leonardochappuis

This comment was marked as spam.

Sign in to view
@JayXTQ
Copy link
Author

JayXTQ commented Nov 15, 2023

Is there any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladfrangu vladfrangu

Labels
feature request packages:core utility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vladfrangu @leonardochappuis @JayXTQ