Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): nav overlap #9720

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

brynpttrsn
Copy link
Contributor

@brynpttrsn brynpttrsn commented Jul 16, 2023

Please describe the changes this PR makes and why it should be merged:

Fixes the nav overlapping the header on small screens/mobile.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Jul 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 6:20pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 6:20pm

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #9720 (005558d) into main (23a6424) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #9720   +/-   ##
=======================================
  Coverage   59.91%   59.91%           
=======================================
  Files         235      235           
  Lines       15963    15963           
  Branches     1210     1210           
=======================================
  Hits         9565     9565           
  Misses       6353     6353           
  Partials       45       45           
Flag Coverage Δ
website 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...c/app/docs/packages/[package]/[version]/layout.tsx 0.00% <0.00%> (ø)
apps/website/src/components/Nav.tsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jul 17, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 71
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-git-fork-brynpttrsn-fix-websitemobile-nav-discordjs.vercel.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

None yet

2 participants