feat(ui): shared button styles #9575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Codecov Report
@@ Coverage Diff @@
## main #9575 +/- ##
==========================================
+ Coverage 58.26% 58.32% +0.06%
==========================================
Files 227 226 -1
Lines 14881 14864 -17
Branches 1133 1132 -1
==========================================
Hits 8670 8670
+ Misses 6171 6154 -17
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds the shared button styles to /ui for reusability.
🤖 Generated by Copilot at 11b8e38
class-variance-authorityfromapps/websitepackage to reduce bundle size and avoid conflicts (link)buttonVariantsfrom local files to@discordjs/uimodules inapps/websitefiles to use consistent and customizable button variants from the library (link, link, link, link, link, link, link)exportsfield topackages/ui/package.jsonto define entry points and submodules of@discordjs/uipackage for bundlers and TypeScript (link)class-variance-authoritytopackages/ui/package.jsonto handle variance of class components in@discordjs/uipackage (link)buttonVariantsas a separate module inpackages/ui/src/lib/index.tsto expose them to the website and the library (link)apps/website/src/styles/Button.tsxtopackages/ui/src/lib/styles/Button.tsto move button variants module to the library (link)moduleResolutionoption totsconfig.jsonfiles inapps/websiteandpackages/uito enable TypeScript to resolve@discordjs/uipackage as a node-compatible or bundler-compatible module (link, link)src/lib/styles/Button.tstooptimizeDeps.includearray inpackages/ui/vite.config.tsto instruct Vite to pre-bundle button variants module for performance and compatibility (link)