perf: linear speed position getters #9528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kyra <kyradiscord@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
jaw0r3k
changed the title
|
Upstream PR landed with different checks. |
|
Please resolve conflicts. |
jaw0r3k
force-pushed
the
v13-linear-speed-position-getters
branch
from
6b9998f
to
e3a6a92
Compare
SpaceEEC
approved these changes
Aug 25, 2023
jaw0r3k
force-pushed
the
v13-linear-speed-position-getters
branch
from
e3a6a92
to
943d486
Compare
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-fork-jaw0r3k-v13-linear-speed-p-f6889b-discordjs.vercel.app/ |
kyranet
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Backports:
The other pr isnt backported as current performance is 59 ms per 100_000 iterations
Where kyra's is 132 ms
Status and versioning classification: