Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix external links #9313

Merged
merged 18 commits into from Apr 7, 2023
Merged

fix: fix external links #9313

merged 18 commits into from Apr 7, 2023

Conversation

TetieWasTaken
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This PR fixes @external links to link to the correct page. Following #9286

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Apr 2, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Apr 7, 2023 10:29am

@vercel
Copy link

vercel bot commented Apr 2, 2023

@TetieWasTaken is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

@Jiralite
Copy link
Member

Jiralite commented Apr 2, 2023

Is it me or none of these links work?

@imranbarbhuiya
Copy link
Contributor

Is it me or none of these links work?

Hard reload to clear cache

Qjuh
Qjuh suggested changes Apr 2, 2023
View reviewed changes
packages/discord.js/src/util/Components.js Outdated Show resolved Hide resolved
packages/discord.js/src/client/BaseClient.js Outdated Show resolved Hide resolved
packages/discord.js/src/client/Client.js Outdated Show resolved Hide resolved
@TetieWasTaken TetieWasTaken mentioned this pull request Apr 2, 2023
Closed
@Jiralite Jiralite added this to the discord.js 14.10 milestone Apr 3, 2023
@Jiralite
Copy link
Member

Jiralite commented Apr 3, 2023

Can you update this one too?

discord.js/packages/discord.js/src/util/Sweepers.js

Line 11 in 0645bf0

* See {@link [Collection#sweep](https://discord.js.org/#/docs/collection/main/class/Collection?scrollTo=sweep)}

@github-actions
Copy link

github-actions bot commented Apr 3, 2023 •
edited

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-guide-git-fork-tetiewastaken-fix-ne-0f5096-discordjs.vercel.app/

@almeidx
Copy link
Member

almeidx commented Apr 4, 2023

Should this one be updated as well? (old.discordjs.dev domain)

discord.js/packages/discord.js/docs/README.md

Line 1 in 0645bf0

## [View the documentation here.](https://discord.js.org/#/docs)

@kyranet @Jiralite
Update packages/util/docs/README.md
93a20c1 
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@Jiralite Jiralite removed the blocked label Apr 7, 2023
@kodiakhq kodiakhq bot merged commit a7425c2 into discordjs:main Apr 7, 2023
5 of 6 checks passed
@TetieWasTaken TetieWasTaken deleted the fix/new-site-links branch April 7, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiralite Jiralite Jiralite approved these changes

@Qjuh Qjuh Qjuh requested changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
documentation packages:brokers packages:builders packages:collection packages:discord.js packages:proxy packages:rest packages:util packages:voice packages:ws semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js 14.10
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@TetieWasTaken @Jiralite @imranbarbhuiya @almeidx @iCrawl @kyranet @SpaceEEC @Qjuh