Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(Builder.from): fix wrong types #10071

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Syjalo
Copy link
Contributor

@Syjalo Syjalo commented Jan 6, 2024

Please describe the changes this PR makes and why it should be merged:

  • APISelectMenuComponent type represents any type of the select menus. Creating specific menu from any one is wrong. For example, UserSelectMenuBuilder.from(<APIRoleSelectComponent>)
  • APIModalComponent type represents modal's components, not the modal component itself

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Syjalo Syjalo requested a review from a team as a code owner January 6, 2024 02:24
Copy link

vercel bot commented Jan 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2024 2:36am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2024 2:36am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

None yet

3 participants