feat: add support for using keyword on discord.js Client and WebSocketManager
#10063
+34
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suneettipirneni
requested review from
vladfrangu,
iCrawl,
kyranet,
didinele,
Jiralite and
SpaceEEC
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10063 +/- ##
==========================================
- Coverage 58.36% 58.35% -0.01%
==========================================
Files 242 243 +1
Lines 17184 17206 +22
Branches 1243 1243
==========================================
+ Hits 10029 10041 +12
- Misses 7110 7120 +10
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
didinele
requested changes
Dec 29, 2023
didinele
requested changes
Dec 29, 2023
suneettipirneni
changed the title
using keyword on Clientusing keyword on discord.js Client and WebSocketManager
didinele
approved these changes
Dec 29, 2023
vladfrangu
reviewed
Dec 29, 2023
vladfrangu
approved these changes
Dec 29, 2023
SpaceEEC
approved these changes
Dec 29, 2023
Qjuh
reviewed
Dec 30, 2023
…eat/using-support
Qjuh
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This adds support for explicit resource management for the
Clientinstances in discord.js, as well as theWebSocketManagerinws. This is done by polyfillingSymbol.disposeandSymbol.asyncDispose(if not already provided by the runtime).Users who support the correct TypeScript project configuration can use the following syntax to clean up resources after the client goes out of scope or if it errors out:
Or if you're using the
WebSocketManagerfrom@discordjs/wsdirectly:Closes #10057
Status and versioning classification: