Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(guild): allow to pass query into get #10052

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(guild): allow to pass query into get #10052

wants to merge 1 commit into from
+6 −2

Conversation

jaw0r3k
Copy link
Contributor

@jaw0r3k jaw0r3k commented Dec 14, 2023

Please describe the changes this PR makes and why it should be merged:

Fixes: #10039

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@jaw0r3k jaw0r3k requested a review from a team as a code owner December 14, 2023 20:25
@vercel Vercel
Copy link

vercel bot commented Dec 14, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 8:25pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 8:25pm

@Jiralite Jiralite added this to the core 1.2.0 milestone Dec 14, 2023
@Jiralite Jiralite removed this from the core 1.2.0 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
api support blocked packages:core semver:major
Projects
discord.js
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@discordjs/core is missing with_counts on guilds.get
4 participants
@jaw0r3k @vladfrangu @kyranet @Jiralite