Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make builders types great again #10026

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor: make builders types great again #10026

wants to merge 6 commits into from
+270 −242

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Dec 4, 2023 •
edited

Please describe the changes this PR makes and why it should be merged:

Simplify builders types to have better docs while (hopefully) not losing functionality or correctness.

Resolves #9292

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 4:09pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 4:09pm

@Jiralite Jiralite added this to the builders 1.8.0 milestone Dec 4, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (651ffc2) 58.34% compared to head (feecaf5) 58.47%.
Report is 3 commits behind head on main.

Files Patch % Lines
...ractions/slashCommands/mixins/SharedSubcommands.ts 97.07% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10026      +/-   ##
==========================================
+ Coverage   58.34%   58.47%   +0.13%     
==========================================
  Files         241      243       +2     
  Lines       17158    17135      -23     
  Branches     1242     1241       -1     
==========================================
+ Hits        10010    10019       +9     
+ Misses       7103     7071      -32     
  Partials       45       45
Flag Coverage Δ
builders 95.56% <98.12%> (+0.03%) ⬆️
next ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qjuh Qjuh marked this pull request as ready for review December 4, 2023 14:20
@Qjuh Qjuh requested a review from a team as a code owner December 4, 2023 14:20
vladfrangu
vladfrangu approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it still works, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@Jiralite Jiralite Jiralite approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/builders

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/builders

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
packages:builders refactor semver:patch
Projects
discord.js
Status: Todo
Milestone
builders 1.8.0
Development

Successfully merging this pull request may close these issues.

Make builders types great again
3 participants
@Qjuh @vladfrangu @Jiralite