Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ThreadMember): remove audit log reason parameter #10023

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ThreadMember): remove audit log reason parameter #10023

wants to merge 1 commit into from
+9 −12

Conversation

Renegade334
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
The Add Thread Member and Remove Thread Member endpoints do not create audit log entries, and therefore do not accept the X-Audit-Log-Reason header.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@Renegade334 Renegade334 requested a review from a team as a code owner December 3, 2023 19:18
@vercel Vercel
Copy link

vercel bot commented Dec 3, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Dec 29, 2023 3:37pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Dec 29, 2023 3:37pm

@Renegade334 Renegade334 mentioned this pull request Dec 28, 2023
Merged
@Jiralite
Copy link
Member

Please resolve conflicts!

@Renegade334
Copy link
Contributor Author

Will rebase when I get the chance. 👍

@Renegade334 Renegade334 force-pushed the threadmember-addremove-no-reason branch from de8f6e4 to 0d94333 Compare December 29, 2023 15:33
@Renegade334 Renegade334 force-pushed the threadmember-addremove-no-reason branch from 0d94333 to 19b93a2 Compare December 29, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiralite Jiralite Jiralite left review comments

@kyranet kyranet kyranet approved these changes

@jaw0r3k jaw0r3k jaw0r3k approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
blocked packages:discord.js semver:major
Projects
discord.js
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Renegade334 @Jiralite @kyranet @jaw0r3k