New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated @discordjs/collection@2.0.0 breaks node16 compatility (EBADENGINE) #10002
Comments
That is intended, Node.js v16 is EOL (End-of-Life) and therefore discouraged from further use, you should start migrating to Node.js v18 or v20 as soon as possible. https://nodejs.org/en/about/previous-releases |
I know that node 16 is EOL but such a breaking change should not be done in a minor or patch release as it would break any existing installation. Some users don't want to or can't update node at the moment. If node 18 is required for discord.js (as it is currently by it's dependencies) this should be a major version increase for discord.js. In the current situation you are saying "Node.js 16.11.0 or newer is required." but require node 18 by @discordjs/collection dependeny. This makes no sense. |
Discord.js imports EDIT: I see where its coming from, which is the internal packages. Realistically, the warning doesn't stop anything and it'll still work. |
@vladfrangu It's coming from |
Yeah it's unfortunate but it functionally doesn't matter. I doubt there's really anything we could implement to collection to actually cause this to break. |
zlib-sync |
Which package is this bug report for?
discord.js
Issue description
When installing recent version of
discord.js
on node 16 an unsupported engine warning will be shown as of the the automatically installed package@discordjs/collection@2.0.0
requires node >= 18.As of the
package.json
fromdiscord.js
it should be compatible with node >=16.11.0 so all depended packages of the discord.js packages should not require a higher version.This issue breaks for example automated pipeline checks here and didn't happen about 3 weeks ago.
Code sample
No response
Versions
Output of
npm ls @discordjs/collection
:Issue priority
Low (slightly annoying)
Which partials do you have configured?
Not applicable
Which gateway intents are you subscribing to?
Not applicable
I have tested this issue on a development release
d0aa8d2
The text was updated successfully, but these errors were encountered: